[0.5.x] Typescript return type for React Inertia useForm() #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Drafting pending review from @timacdonald |
|
Would it be possible to review this soon? Many thanks. |
|
I just realized that Inertia wasn't exporting the form props for React. I submitted a pull request to fix that, after which this pull request will work. |
|
@joelstein, just a heads up that PR is to your personal repository and not the official Inertia project. |
|
I'll be taking a look at this one soon. |
|
Good catch! 🤦♂️ Here you go: inertiajs/inertia#2166 |
timacdonald
changed the title
|
I believe the required Inertia PR should be released this week. After that I'll start taking a closer look at this one and see if we can get it shipped. |
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The React Inertia useForm() hook is typed to return
any, but we can improve this by returningForm<Data>, similar to the React Vue plugin.However, there's no types.ts file in the
react-inertiapackage, though the file exists in thevue-inertiapackage.https://github.com/laravel/precognition/tree/main/packages/react-inertia/src
https://github.com/laravel/precognition/tree/main/packages/vue-inertia/src
I copied the types.ts file from vue-inertia, modified it with the correct imports, and updated the useForm() return type.